Skip to content
This repository has been archived by the owner on Dec 19, 2018. It is now read-only.

Add back fallback to the entry assembly for application name #1177

Closed
JunTaoLuo opened this issue Aug 18, 2017 · 4 comments
Closed

Add back fallback to the entry assembly for application name #1177

JunTaoLuo opened this issue Aug 18, 2017 · 4 comments
Assignees
Labels

Comments

@JunTaoLuo
Copy link
Contributor

Original issue: #1137

@davidfowl
Copy link
Member

We should fallback to Assembly.GetEntryAssembly().FullName

@JunTaoLuo
Copy link
Contributor Author

JunTaoLuo commented Aug 19, 2017

I dont' think that's what we want:
Assembly.GetEntryAssembly().FullName gives testhost, Version=15.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a
I think we want:
Assembly.GetEntryAssembly().GetName().Name gives testhost

Note testhost is the assembly name as I'm debugging a test.

@JunTaoLuo
Copy link
Contributor Author

JunTaoLuo commented Aug 19, 2017

Seems GetEntryAssembly() returns null when run inside a net461 test launched by xunit. It works fine for netcoreapp tests or executing samples targeting net461.

@Eilon
Copy link
Member

Eilon commented Aug 24, 2017

Not planning to take this in the patch. The provided workaround in the original bug seems to be sufficient. If we see more people hitting this we will reconsider.

@Eilon Eilon closed this as completed Aug 24, 2017
@Eilon Eilon added wontfix and removed 1 - Ready labels Aug 24, 2017
@Eilon Eilon removed this from the 2.0.3 milestone Oct 23, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants