Skip to content
This repository has been archived by the owner on Dec 19, 2018. It is now read-only.

Move some WebHostBuilderExtensions to Hosting.Abstractions #675

Closed
Tratcher opened this issue Mar 24, 2016 · 7 comments
Closed

Move some WebHostBuilderExtensions to Hosting.Abstractions #675

Tratcher opened this issue Mar 24, 2016 · 7 comments
Assignees
Milestone

Comments

@Tratcher
Copy link
Member

IISIntegration was able to depend just on Hosting.Abstractions until it called CaptureStartupErrors.

Move extensions that may be used by extensions from other packages and not just app code. E.g:

  • UseConfiguration
  • CaptureStartupErrors
  • UseEnvironment
  • UseUrls
  • Start

Don't move:

  • UseStartup
  • UseDefaultHostingConfiguration
  • UseServer? - What if I wanted a UseKestrel extension?
  • UseContentRoot
  • UseWebRoot

https://github.com/aspnet/Hosting/blob/dev/src/Microsoft.AspNetCore.Hosting/WebHostBuilderExtensions.cs

@JunTaoLuo @davidfowl

@davidfowl
Copy link
Member

Why not move everything that can be moved?

@Tratcher
Copy link
Member Author

Doesn't matter, as long as it doesn't require too much implementation code or any dependencies.

@pawchen
Copy link

pawchen commented May 21, 2016

I'm confused. Why webroot is not the configuration that comes with StaticFiles? It looks to me that only the StaticFile module is interested in setting the dir where it would find files to serve.

@davidfowl
Copy link
Member

StaticFiles and MVC use the webroot folder by default for serving files. It's in hosting because it flows via the IHostingEnvironment service.

@pawchen
Copy link

pawchen commented May 21, 2016

Thanks, @davidfowl, when does MVC need webroot folder to serve files? I'm under the impression this should be done by StaticFiles.

@pawchen
Copy link

pawchen commented May 21, 2016

Oh I see. It's in the core. Thank you very much!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants