Skip to content
This repository has been archived by the owner on Dec 20, 2018. It is now read-only.

GetTokenAsync and RemoveTokenAsync is not virtual #1041

Closed
msmolka opened this issue Dec 1, 2016 · 4 comments
Closed

GetTokenAsync and RemoveTokenAsync is not virtual #1041

msmolka opened this issue Dec 1, 2016 · 4 comments
Assignees
@HaoK
Labels
3 - Done bug
Milestone
2.0.0-preview1

Comments

@msmolka
Copy link

msmolka commented Dec 1, 2016

GetTokenAsync and RemoveTokenAsync should be virtual methods
@blowdart
Copy link
Member

blowdart commented Dec 7, 2016

What's your justification/scenarios here?

@blowdart
Copy link
Member

blowdart commented Dec 7, 2016

Part of #1040

@HaoK
Copy link
Member

HaoK commented Dec 7, 2016

This will actually be fixed as part of #1043 we did'nt have a public API validation test turned on for the EF core package which is why there were a few missing virtuals

@HaoK
Copy link
Member

HaoK commented Dec 12, 2016

5e4e9cc

@HaoK HaoK closed this as completed Dec 12, 2016
@HaoK HaoK added this to the 1.2.0 milestone Dec 12, 2016
@HaoK HaoK self-assigned this Dec 12, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@HaoK HaoK

Labels
3 - Done bug
Projects
None yet
Milestone
2.0.0-preview1
Development

No branches or pull requests
3 participants
@blowdart @HaoK @msmolka