Skip to content
This repository has been archived by the owner on Dec 20, 2018. It is now read-only.

UserManager.ThrowIfDisposed should be protected #762

Closed
mwpowellhtx opened this issue Mar 6, 2016 · 3 comments
Closed

UserManager.ThrowIfDisposed should be protected #762

mwpowellhtx opened this issue Mar 6, 2016 · 3 comments
Assignees
Milestone

Comments

@mwpowellhtx
Copy link

Hello,

In UserManager, ThrowIfDisposed should be protected. Today it is private.

protected void ThrowIfDisposed()
{
    if (_disposed)
    {
        throw new ObjectDisposedException(GetType().Name);
    }
}

Tangent to that is to expose an IsDisposed property.

Thank you.

@blowdart blowdart added the bug label Mar 9, 2016
@blowdart blowdart added this to the 1.0.0-rc2 milestone Mar 9, 2016
@blowdart
Copy link
Member

blowdart commented Mar 9, 2016

Linked to #750

@mwpowellhtx
Copy link
Author

Thanks...

@HaoK
Copy link
Member

HaoK commented Mar 10, 2016

41fa99e

@HaoK HaoK closed this as completed Mar 10, 2016
@HaoK HaoK added the 3 - Done label Mar 10, 2016
@divega divega changed the title ThrowIfDisposed should be protected UserManager.ThrowIfDisposed should be protected May 16, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants