This repository has been archived by the owner on Oct 18, 2018. It is now read-only.
Add linux-musl-x64 shared runtime #1104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 23, 2018
|
Change looks good to me but I don't know your infra as well as others. |
|
Talked to @muratg. Merging as we are considering this a continuation of the linux-musl work done by the core-setup team. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
React to dotnet/corefx#28560 and dotnet/coreclr#17623 - the base sharedfx is moving to 'linux-musl'.
Note: we will still keep
alpine.3.6-x64for now. It's not clear we need to drop it in order to ship 2.1, and there is less risk if we simply add linux-musl side by side for now.