Skip to content
This repository has been archived by the owner on May 31, 2019. It is now read-only.

Migrate to dotnet repo #403

Closed
glennc opened this issue Mar 29, 2018 · 17 comments
Closed

Migrate to dotnet repo #403

glennc opened this issue Mar 29, 2018 · 17 comments
Assignees

Comments

@glennc
Copy link
Member

glennc commented Mar 29, 2018

See: aspnet/Announcements#298

@felipepessoto
Copy link

Are the versions 2.1-sdk and runtime RTM? https://hub.docker.com/r/microsoft/dotnet/tags/

@natemcmaster
Copy link
Contributor

Not yet. These tags currently point to 2.1-preview1. (cc @MichaelSimons @richlander)

@richlander
Copy link
Member

Right, preview 1. That is all pretty clear -> https://hub.docker.com/r/microsoft/dotnet/

There will be a preview 2, too.

@natemcmaster
Copy link
Contributor

The work to move these images was done and builds are now available. See https://hub.docker.com/r/microsoft/dotnet-nightly/ to try the new runtime images.

FROM microsoft/dotnet-nightly:2.1-aspnetcore-runtime

I've also removed the code from the dev branch of this repo for producing nightly builds of 2.1-preview2. Once preview2 ships, I'll also remove the code for the 2.1-preview1 images currently in master.

@natemcmaster natemcmaster added this to the 2.1.0-preview2 milestone Apr 2, 2018
@Eilon Eilon added the task label Apr 2, 2018
@muratg
Copy link

muratg commented Apr 3, 2018

@natemcmaster any work remaining before this can be closed?

@natemcmaster
Copy link
Contributor

Just the cleanup I mentioned in my previous comment. That can wait until after preview2 has been released.

@ThaDaVos
Copy link

Currently when updating my dockerfile to use
microsoft/dotnet:2.1-aspnetcore-runtime AS base
and
microsoft/dotnet:2.1-sdk AS build
I'm not able to boot it up using visual studio and get my project running...
Getting the following error
https://pasteboard.co/HgoXR2B.png

@natemcmaster
Copy link
Contributor

I recommend opening a bug using VS's Report a problem feature, or here: http://developercommunity.visualstudio.com. I have a hunch it's a bug in VS, not in the Docker images themselves, but I'm not the right one to give a certain answer for that, sorry.

@dapalmi
Copy link

dapalmi commented Apr 14, 2018

Same problem as @dvdbot.
With which VS version did you test those docker images?

@ThaDaVos
Copy link

Latest preview version because it's needed for developing with the latest preview of .net core

@dapalmi
Copy link

dapalmi commented Apr 14, 2018

Thanks. Sorry. My question was for the aspnet-docker people. Did you test those images with VS 2017?

@MichaelSimons
Copy link
Contributor

@dvdbot, @dapalmi - I think you've encountered an issue with the VS debugger similar to the issue described here. Can you try working around this by adding RUN apt-get install -y --no-install-recommends libcurl3 libunwind8 libuuid1 to your Dockerfile?

@ThaDaVos
Copy link

Where in the docker file do we add this?
In the FROM *** as build or FROM *** as base?

@ThaDaVos
Copy link

Tried adding it after FROM microsoft/dotnet:2.1-aspnetcore-runtime AS base but gave me an error because it could not find libundwind8

@MichaelSimons
Copy link
Contributor

@dvdbot - add it to the base stage. You will need to do an apt-get- update first.

FROM microsoft/dotnet:2.1-aspnetcore-runtime AS base
RUN apt-get update \
	&& apt-get install -y --no-install-recommends \
		libcurl3 \
		libunwind8 \
		libuuid1 \
	&& rm -rf /var/lib/apt/lists/*
...

@ThaDaVos
Copy link

It works!
Thanks - that I forgot about apt-get update :O

So it only has to be added here too and it's fixed?
https://github.com/dotnet/dotnet-docker/blob/master/2.1/runtime-deps/stretch-slim/amd64/Dockerfile

@MichaelSimons
Copy link
Contributor

The underlying issue is in VS Docker Tools - not the Docker images. I logged microsoft/DockerTools#95 to track the VS issue (they are already aware of the issue and working on a fix).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

9 participants