Skip to content
This repository has been archived by the owner on Dec 16, 2023. It is now read-only.

ProxyRequest URL encodes URLs giving different behaviour to default node behaviour #133

Open
TTransmit opened this issue Aug 3, 2017 · 0 comments

Comments

@TTransmit
Copy link

TTransmit commented Aug 3, 2017

We have hit a minor gotcha when using node-replay.

The following line URL encodes the URL and request parameters when using record mode in replay: https://github.com/assaf/node-replay/blob/master/src/proxy.js#L44

When running requests through replay, replay will correctly escape a request like https://www.example.com/test?query={"title":"Node replay is great"} to https://www.example.com/test?query=%7B%22title%22%3A%22Node%20replay%20is%20great%22%7D. The node app running locally doesn't encode the URLs. This gave a difference between behaviour during test driven development with replay and behaviour of the node app itself.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant