checkfunargs: use defaults, allow ellipses #102
Conversation
| @@ -313,16 +313,22 @@ function( x0, | |||
| if( any(is.na(m1)) ){ | |||
| mx1 = which( is.na(m1) ) | |||
| for( i in 1:length(mx1) ){ | |||
| stop(paste(funname, " requires argument '", fnms[mx1[i]], "' but this has not been passed to the 'nloptr' function.\n", sep = "")) | |||
| has_default = !(fnms[mx1[i]] == "") | |||
There was a problem hiding this comment.
You should be checking the value in the list here, not the name, i.e. has_default = flist[[mx1[i] + 1]] != "".
| for( i in 1:length(mx2) ){ | ||
| stop(paste(rnms[mx2[i]], "' passed to (...) in 'nloptr' but this is not required in the ", funname, " function.\n", sep = "")) | ||
| if( !("..." %in% names(flist)) ) { | ||
| m2 = match(rnms, fnms) |
There was a problem hiding this comment.
Why do you run again this? It is already in m1, isn't it?
| } | ||
| } | ||
| m2 = match(rnms, fnms) |
There was a problem hiding this comment.
Why do you run again this? It is already in m1, isn't it?
| if( any(is.na(m2)) ){ | ||
| mx2 = which( is.na(m2) ) | ||
| for( i in 1:length(mx2) ){ | ||
| stop(paste(rnms[mx2[i]], "' passed to (...) in 'nloptr' but this is not required in the ", funname, " function.\n", sep = "")) |
There was a problem hiding this comment.
Please remove parenthesis around ellipsis.
|
Hi @gkane26. Thanks for the PR. I do not know whether you had a chance to see my comments and finalise the PR so that we could close the related issue. Let me know. |
|
Would you like me to take another crack at this? It seems that this would be easier to implement by starting here and adding flist <- formals(fun) ## existing code
flist <- flist[setdiff(names(flist), "...")] ## newalthough admittedly I haven't checked to see if there are any surprises down the line. |
|
I’m not in front of my computer, but if I recall correctly, some of the helper wrapper functions use the ellipse to pass parameters to the underlying |
|
If you have time, that would be great. |
|
It seems related to #37 as well. |
Small edits to allow the use of ellipses in the objective function. I've used this a bit for personal use, but it hasn't undergone extensive testing.