Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsets should always be considered successful #640

Closed
rbino opened this issue Feb 7, 2022 · 1 comment
Closed

Unsets should always be considered successful #640

rbino opened this issue Feb 7, 2022 · 1 comment

Comments

@rbino
Copy link
Collaborator

rbino commented Feb 7, 2022

This is related to #438, which fixed this for properties setting but didn't fix it for properties unset. For the same reason, unsets should always return 200 OK regardless of the number of matches on the broker because:

  • If a session is present, the unset will be sent when the device reconnects
  • If a session is not present (or the device asks for a clean one on reconnect), the information of the unset path will be delivered by the /control/consumerProperties message.

Incidentally, there's currently another bug because the unset gets saved in the database before checking the return value of ensure_unset, but this was not put in a separate issue because after this issue is fixed ensure_unset will always succeed by construction, thus making it always valid to save the value to the DB before it is sent.

Reported by @szakhlypa

@rbino rbino changed the title Unsets should be always considered successful Unsets should always be considered successful Feb 7, 2022
@Annopaolo
Copy link
Collaborator

Closed by #691.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants