_reorder_sources() in OLA compares scaled/windowed frame with un-scaled/un-windowed frame #688
Conversation
…he way it had been coded, the previous frame might have been scaled or windowed already. But to get best results, we probably want to compare to an unscaled, un-windowed version.
|
Hey, Look at the diff, because you changed other things (formating), the diff is much less clear. Can you change only the functional part of the code you intend to change please ? |
|
Looked at the diff—I don't think I have changed the formatting. 🤷♂️ |
| if self.use_window: | ||
| frame = frame * self.window.to(frame) | ||
| frame *= self.window.to(frame) |
There was a problem hiding this comment.
This is not a functional change, only cosmetic.
There was a problem hiding this comment.
If I am not mistaken, *= acts in-place, so the frame tensor itself gets modified, meaning that the frame in the out list is also modified.
frame = frame * self.window.to(frame) would not accomplish this, would it?
There was a problem hiding this comment.
Indeed, I misread the logic at first, thanks.
| else: | ||
| frame = frame / (self.window_size / self.hop_size) | ||
| out.append(frame) | ||
| frame /= self.window_size / self.hop_size |
|
You are right, it was functional because of the inplace modification I didn't get. Merging. |
Hey there,
_reorder_sources()is called with the current and the previous frames as arguments. The way it had been coded, the previous frame might have been scaled or windowed already. But to get best results, we probably want to compare to an unscaled, un-windowed version. That's what this change fixes.Cheers.