Fix dns_challenge recipe issue forcing INTERSPEECH 2020 branch #700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current master of the dns_challenge repo does not work with the dns_challenge asteroid recipe. Many scripts have either changed, moved, or have been removed. The version of the dns_challenge repo which was intended to be used was from INTERSPEECH 2020.
This PR does two things
interspeech2020/masterbranch rather than themaster, in thedownload_data.shscriptdns_challengerecipe directory name todns_challenge_INTERSPEECH2020to indicate that the recipe is meant to use a specific version of the dataset (and dataset repo).