Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug report] Parallel sampler hanging on shutdown #210

Open
joel99 opened this issue Oct 11, 2021 · 0 comments
Open

[Bug report] Parallel sampler hanging on shutdown #210

joel99 opened this issue Oct 11, 2021 · 0 comments

Comments

@joel99
Copy link

joel99 commented Oct 11, 2021

Hi,

I recently started using this wonderful library, but have been occasionally experiencing a small quality-of-life issue where parallel.base.ParallelSamplerBase.shutdown hangs after all the workers have finished, but the worker processes don't get joined. (I'm using the GPUSampler for basic, 1-GPU, multi-worker training.) Based on this SO post and seeing some other drain statements in the file, I think adding the following to .shutdown() patches the issue:

drain_queue(self.traj_infos_queue)
drain_queue(self.eval_traj_infos_queue)

Hope this means something to you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant