Skip to content
This repository has been archived by the owner on Apr 15, 2022. It is now read-only.

updating to lastest bs-css changes #2

Open
drejohnson opened this issue May 3, 2018 · 3 comments
Open

updating to lastest bs-css changes #2

drejohnson opened this issue May 3, 2018 · 3 comments

Comments

@drejohnson
Copy link
Contributor

drejohnson commented May 3, 2018

Not sure if you have moved on from this project or not but I've forked and began updating this to match latest changes to bs-css. Everything works but I haven't figured out 'keyframes`. Would you mind taking a look.

Also I've updated bs-react-fela, which I used to test the changes I made to bs-css-core. The only issue is that createComponentWithProxy is broken. You can find the code in examples.

Thanks for any help or guidance you can provide

@astrada
Copy link
Owner

astrada commented May 3, 2018

Thanks for your effort. I was thinking about updating it, but I didn't have the time. The keyframe tests are wrong. Digging in CSS specs (working on https://github.com/astrada/ppx_bs_css), I found that there is no way to use an inline keyframe as animation-name value, so that part needs to be reviewed.

@astrada
Copy link
Owner

astrada commented Aug 12, 2018

I've updated the package to v7.0.1 of bs-css. I've also published the package to npm. I've added my scope, so you now have to use @astrada/bs-css-core and removed namespace so you don't have to reference module BsCssCore anymore.

@astrada
Copy link
Owner

astrada commented Aug 12, 2018

Also I've updated bs-react-fela, which I used to test the changes I made to bs-css-core. The only issue is that createComponentWithProxy is broken. You can find the code in examples.

I think I found the problem and opened an issue on fela's repo. See robinweser/fela#595.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants