-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pick up pyproject.toml
based on file path or workspace
#3
Comments
This would be quite useful for me, would you accept a PR implementing it? EDIT: it seems like this already works actually |
I wonder how that works, I would've expected it not to since we don't use the passed-in path to infer the project root 🤔 |
Oh, we pass the stdin filename, of course... |
@charliermarsh does this issue mean that the selected rules from pyproject.toml would supersede/take precedence over what you have in your vscode settings? I don't think this works currently but I would really like to see this. When working in a team where everyone has individual vscode settings, it's confusing to talk about which ruff rules you want in your project - when you don't see warnings in vscode based on the pyproject.toml for that project. I appreciate that different people might desire different behavior here so maybe a ruff-vscode setting would be preferable here which makes it possible to specify which takes precedence; pyproject.toml or vscode settings. I also posted about this over at mastodon (here). |
Yeah, that's correct -- the The best way to solve this today is to use a user-specific |
@charliermarsh thanks for this - great that there's this workaround. Is this |
No description provided.
The text was updated successfully, but these errors were encountered: