Different results between CLI and Pre-Commit

[GoncaloGuedes]

I've set up a pre-commit hook using Ruff to handle linting in my project. I've configured the hook as per the documentation:

- repo: https://github.com/astral-sh/ruff-pre-commit
  rev: v0.4.9
  hooks:
    - id: ruff
      args: [ --fix ]
    - id: ruff-format

To test this setup, I've created a script a.py with the following content:

"""Module contains functions related to greetings."""

def get_greeting(name: str) -> str:
    """Return a greeting message.

    Args
        name (str): Name of the person to greet.

    Returns
        str: A greeting message.

    """
    return f"Hello, {name}!"

def hello() -> str:
    return "hello"

Running ruff check from the command line gives me 3 errors:

a.py:8:5: D416 [*] Section name should end with a colon ("Args")
a.py:12:5: D416 [*] Section name should end with a colon ("Returns")
a.py:20:5: D103 Missing docstring in public function
Found 3 errors.
[*] 2 fixable with the `--fix` option.

However, when I run pre-commit, it passes without any errors. Am I missing something in my configuration?

[MichaReiser]

I suspect that ruff fixes the error when running the pre-commit because you configured the hook with the --fix argument.

To compare, you can try running ruff check --fix in the CLI.

[GoncaloGuedes]

Yeah, I was expecting Ruff to change on the pre-commit. However, it does not change and the test is classified as 'passed'.

[zanieb]

Is a.py a staged file in git?

[Avasam]

Is a.py a staged file in git?

This. You can use pre-commit run --all to run on all files.

[simon376]

I have a similar issue. I use a pyproject.toml file in the root directory, which get's correctly identified if I check via ruff check --show-settings, however the formatting applied when using the pre-commit hook vs. the VSCode Extension (which uses the native server) differs, leading to whitespace / indentation changes all the time.

how can I check / make sure both use the same settings and do not differ at all?
I tried manually passing the absolute path to the config file in the vs code settings, but that didn't make any difference. I did not modify any VSCode Extension settings or any customization in the pre-commit hook either

[dhruvmanila]

Can you specify whether it's pre-commit or the VS Code extension which isn't identifying the config file? If it's the latter, can you open an issue at https://github.com/astral-sh/ruff-vscode?

[simon376]

explicitly passing --config=pyproject.toml to the pre-commit hook ended up fixing the problem, so it's the former.