Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate token ranges in the parser tests #11938

Closed
dhruvmanila opened this issue Jun 19, 2024 · 0 comments · Fixed by #12019
Closed

Validate token ranges in the parser tests #11938

dhruvmanila opened this issue Jun 19, 2024 · 0 comments · Fixed by #12019
Labels
parser Related to the parser testing Related to testing Ruff itself

Comments

@dhruvmanila
Copy link
Member

dhruvmanila commented Jun 19, 2024 •
edited
Loading

Issues such as #11937, #11929 basically suggests that the token ranges are overlapping which is causing the panic in downstream tools.

I think it would be useful to validate the parsed output in the test cases to make sure that the token ranges don't overlap. This would be similar to the validation done on the AST.
@dhruvmanila dhruvmanila added parser Related to the parser testing Related to testing Ruff itself labels Jun 19, 2024
@dhruvmanila dhruvmanila mentioned this issue Jun 25, 2024
Merged
@dhruvmanila dhruvmanila linked a pull request Jun 25, 2024 that will close this issue
Update parser tests to validate token ranges #12019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
parser Related to the parser testing Related to testing Ruff itself
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update parser tests to validate token ranges astral-sh/ruff
1 participant
@dhruvmanila