Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RUF025 duplicates unimplemented rule C420 #12110

Closed
tjkuson opened this issue Jun 30, 2024 · 1 comment · Fixed by #12533
Closed

RUF025 duplicates unimplemented rule C420 #12110

tjkuson opened this issue Jun 30, 2024 · 1 comment · Fixed by #12533
Assignees
@charliermarsh
Labels
rule Implementing or modifying a lint rule
Milestone
v0.6

Comments

@tjkuson
Copy link
Contributor

tjkuson commented Jun 30, 2024

unnecessary-dict-comprehension-for-iterable (RUF025) now exists as a flake8-comprehensions rule (adamchainz/flake8-comprehensions#553).

Although C420 has not been implemented yet, it would make sense (and seems to match what has been done before) to merge the rules in favour of the flake8 plugin. Although the rule request was made to Ruff first (#9592, adamchainz/flake8-comprehensions#552), my understanding is that Ruff favours strong coupling to flake8.

search terms: RUF025, flake8-comprehensions, duplicate, duplication

Related to #2714
@charliermarsh
Copy link
Member

Cool, makes sense to me to redirect it to C420! Thanks for doing that.

@charliermarsh charliermarsh added the rule Implementing or modifying a lint rule label Jun 30, 2024
@MichaReiser MichaReiser added this to the v0.6 milestone Jun 30, 2024
@Skylion007 Skylion007 mentioned this issue Jul 14, 2024
Closed
@charliermarsh charliermarsh self-assigned this Jul 26, 2024
@charliermarsh charliermarsh mentioned this issue Jul 26, 2024
Merged
MichaReiser pushed a commit that referenced this issue Aug 12, 2024
@charliermarsh
Re-code unnecessary-dict-comprehension-for-iterable (RUF025) as `…
4ec340a 
…C420` (#12533)

Closes #12110.
AlexWaygood pushed a commit that referenced this issue Aug 14, 2024
@charliermarsh @AlexWaygood
Re-code unnecessary-dict-comprehension-for-iterable (RUF025) as `…
10c58a2 
…C420` (#12533)

Closes #12110.
MichaReiser pushed a commit that referenced this issue Aug 14, 2024
@charliermarsh @MichaReiser
Re-code unnecessary-dict-comprehension-for-iterable (RUF025) as `…
e4de0e9 
…C420` (#12533)

Closes #12110.
MichaReiser pushed a commit that referenced this issue Aug 14, 2024
@charliermarsh @MichaReiser
Re-code unnecessary-dict-comprehension-for-iterable (RUF025) as `…
78a7ac0 
…C420` (#12533)

Closes #12110.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@charliermarsh charliermarsh

Labels
rule Implementing or modifying a lint rule
Projects
None yet
Milestone
v0.6
Development

Successfully merging a pull request may close this issue.

Re-code unnecessary-dict-comprehension-for-iterable (RUF025) as C420 astral-sh/ruff
3 participants
@MichaReiser @charliermarsh @tjkuson