Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect fix suggested for FURB189 #14274

Closed
penguinolog opened this issue Nov 11, 2024 · 2 comments
Closed

Incorrect fix suggested for FURB189 #14274

penguinolog opened this issue Nov 11, 2024 · 2 comments

Comments

@penguinolog
Copy link

Preview check FURB189 suggest using collections.UserStr, but correct base class if collections.UserString (https://docs.python.org/3/library/collections.html#userstring-objects)

Example code to trigger checker:

class MyStr(str):
    __ slots__ = ()

Check command used: ruff check --preview --select=FURB189

Ruff version: 0.7.3

@penguinolog penguinolog changed the title Incorrect fix proposed for FURB189 Incorrect fix suggested for FURB189 Nov 11, 2024
@sbrugman
Copy link
Contributor

Hi @penguinolog thanks for flagging this!

The issue has already been resolved in main and will be fixed in the upcoming release (#14209).

@penguinolog
Copy link
Author

Closing as duplicate for fixed #14209

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants