Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hardcoded workspace_refresh client capability #15013

Closed
dhruvmanila opened this issue Dec 16, 2024 · 1 comment · Fixed by #15014
Closed

Remove hardcoded workspace_refresh client capability #15013

dhruvmanila opened this issue Dec 16, 2024 · 1 comment · Fixed by #15014
Assignees
Labels
bug Something isn't working server Related to the LSP server

Comments

@dhruvmanila
Copy link
Member

Resolve the following todo:

let workspace_refresh = true;
// TODO(jane): Once the bug involving workspace.diagnostic(s) deserialization has been fixed,
// uncomment this.
/*
let workspace_refresh = client_capabilities
.workspace
.as_ref()
.and_then(|workspace| workspace.diagnostic.as_ref())
.and_then(|diagnostic| diagnostic.refresh_support)
.unwrap_or_default();
*/

This should address #10581 (comment).

@dhruvmanila dhruvmanila added bug Something isn't working server Related to the LSP server labels Dec 16, 2024
@dhruvmanila
Copy link
Member Author

So, the PR hasn't been merged yet in the original repository: gluon-lang/lsp-types#281 but our forked version does contain this fix which we're using.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working server Related to the LSP server
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant