--fix-only returns exit code 1 upon fixes

[spapanik]

Thank you for the great work! Ruff is fantastic, and I have replaced all my linters with it. I just have a small feature request on the fixers of it.

Now, the cli options to fix the ruff issues are: ruff --fix . and ruff --fix-only . They are a bit problematic to work with in scripts, as even if they fix all the issues that are fixable, the exit code can be zero, if there are no fixable issues. There is the obvious workaround of adding || true, but this will mask all errors, for example ruff itself panicking instead of fixing the fixable issues. A new option that would allow just run it in fix mode.

[JonathanPlasse]

Would --exit-non-zero-on-fix work for you?

[spapanik]

@JonathanPlasse it does exactly the opposite. I was looking for a --exit-zero-on-fix. Let me explain the scenario: I have two errors in my code: I001 which is fixable, and N801 that's not fixable. What I would like to do is run it, fix I001 and return 0, because it successfully fixed all the fixable errors. Now, the closest is to do ruff --fix-only . || true but this means that if ruff breaks, I will still get an exit code 0, which is wrong.

[charliermarsh]

I assumed that if you run Ruff in that scenario with ruff --fix-only ., and it fixed I001 but left N801, it would exit with code 0. Does it not?

[spapanik]

No, it doesn't:

venv:(***)$ ~/programming/*** git:(main) ✗
stephanos@marco $ ruff --fix-only foo.py
Fixed 1 error.
venv:(***)$ ~/programming/*** git:(main) ✗
stephanos@marco $ echo $?
1

[charliermarsh]

Ahh ok, that strikes me as a bug, but will look into it.

[charliermarsh]

I guess, in this framing, ruff --fix-only would always return 0 (unless the program hit an internal error), whereas ruff --fix-only --exit-non-zero-on-fix would return 1 when at least one error was fixed. Is that right?