Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Format PatternMatchStar #6558

Closed
Tracked by #5834
dhruvmanila opened this issue Aug 14, 2023 · 2 comments · Fixed by #6653
Closed
Tracked by #5834

Format PatternMatchStar #6558

dhruvmanila opened this issue Aug 14, 2023 · 2 comments · Fixed by #6653
Assignees
@harupy
Labels
formatter Related to the formatter good first issue Good for newcomers help wanted Contributions especially welcome
Milestone
Formatter: Alpha

Comments

@dhruvmanila
Copy link
Member

dhruvmanila commented Aug 14, 2023 •
edited by MichaReiser
Loading

This would be done in a similar manner as mentioned here (#6555 (comment)) except that this would be delegated to Identifier formatting instead.

Implement formatting for the *pat pattern

match x:
    case [1, 2, *rest]:
        ...
    case [*_]:
        ...
@dhruvmanila dhruvmanila mentioned this issue Aug 14, 2023
Closed
12 tasks
@dhruvmanila dhruvmanila added good first issue Good for newcomers formatter Related to the formatter labels Aug 14, 2023
@dhruvmanila dhruvmanila added this to the Formatter: Alpha milestone Aug 14, 2023
@MichaReiser MichaReiser added the help wanted Contributions especially welcome label Aug 17, 2023
@harupy
Copy link
Contributor

harupy commented Aug 17, 2023

Can I work on this?

@MichaReiser
Copy link
Member

Sure!

@harupy harupy mentioned this issue Aug 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@harupy harupy

Labels
formatter Related to the formatter good first issue Good for newcomers help wanted Contributions especially welcome
Projects
None yet
Milestone
Formatter: Alpha
Development

Successfully merging a pull request may close this issue.

Format PatternMatchStar harupy/ruff
3 participants
@MichaReiser @harupy @dhruvmanila