Formatter: With Item parentheses

[MichaReiser]

Input

if True:
    with (
        anyio.CancelScope(shield=True)
        if get_running_loop()
        else contextlib.nullcontext()
    ):
        pass

if True:
    with (
        anyio.CancelScope(shield=True)
        and B and [aaaaaaaa, bbbbbbbbbbbbb, cccccccccc, dddddddddddd, eeeeeeeeeeeee]
    ):
        pass

Black

if True:
    with (
        anyio.CancelScope(shield=True)
        if get_running_loop()
        else contextlib.nullcontext()
    ):
        pass

if True:
    with (
        anyio.CancelScope(shield=True)
        and B
        and [aaaaaaaa, bbbbbbbbbbbbb, cccccccccc, dddddddddddd, eeeeeeeeeeeee]
    ):
        pass

Ruff

if True:
    with anyio.CancelScope(
        shield=True
    ) if get_running_loop() else contextlib.nullcontext():
        pass

if True:
    with anyio.CancelScope(shield=True) and B and [
        aaaaaaaa,
        bbbbbbbbbbbbb,
        cccccccccc,
        dddddddddddd,
        eeeeeeeeeeeee,
    ]:
        pass

Expected

Ruff uses the maybe_parenthesize (can omit optional parentheses) layout where black seems not to.

I'm not sure if I agree with this choice because Black/Ruff use the maybe_parenthesize layout consistently in all other clause header positions.

[charliermarsh]

This is a bug -- we should be preserving the parentheses. We do the right thing with if statements:

if True:
    with (
        anyio.CancelScope(shield=True)
        if get_running_loop()
        else contextlib.nullcontext()
    ):
        pass

if True:
    if (
        anyio.CancelScope(shield=True)
        if get_running_loop()
        else contextlib.nullcontext()
    ):
        pass

[charliermarsh]

Not a blocker for the Beta, but we may fix it anyway this month.

[charliermarsh]

Not totally trivial in part due to the as.

[charliermarsh]

I believe this was closed by #7694.