Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format as lint rule #8229

Closed
hmvp opened this issue Oct 25, 2023 · 1 comment
Closed

Format as lint rule #8229

hmvp opened this issue Oct 25, 2023 · 1 comment
Labels
formatter Related to the formatter

Comments

@hmvp
Copy link

hmvp commented Oct 25, 2023

Congrats on the release with the new formatter. Besides a few changed lines that I still need to investigate It looks really good!

I was a bit surprised with the fact that it is only a separate command. I kind of expected it to work as a lint rule: RUF300: Code not formatted or something... Which of course includes an autofix.

Using Ruff would allow me to drop 3 tools (flake8, isort, black) but I still need to run two commands...

I also noticed #8185 and feel that those warnings are better suited in the case that the formatter is enabled as lint rule. It seems to me that as a separate command you might want to differ between formatting and conflicting lint rules...

@zanieb
Copy link
Member

zanieb commented Oct 25, 2023

Thanks!

We're planning to integrate the formatter and linter into a single command as a part of the "Stable" formatter release.

Some previous mentions at #7310 (reply in thread), #7310 (comment), and #7232

I'm going to close this issue in favor of a tracking issue at #8232 which we'll use for general updates on this feature — implementing as a lint rule is only one of the possible interfaces.

@zanieb zanieb closed this as not planned Won't fix, can't repro, duplicate, stale Oct 25, 2023
@zanieb zanieb added the formatter Related to the formatter label Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
formatter Related to the formatter
Projects
None yet
Development

No branches or pull requests

2 participants