Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

F401 - Distinguish between imports we wish to remove and those we wish to make explicit-exports #11168

Merged
merged 36 commits into from
May 2, 2024
Merged

F401 - Distinguish between imports we wish to remove and those we wish to make explicit-exports #11168

merged 36 commits into from
May 2, 2024

Commits on Apr 30, 2024

  1. [ruff F401 #10390 #10391] categorize imports that this rule will appl… 

    …y to
    @plredmond
    plredmond committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    e8ccbc1 View commit details
    Browse the repository at this point in the history

  2. [ruff F401 #10390 #10391] add import category to ImportBinding struct

    @plredmond
    plredmond committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    c3cb1fc View commit details
    Browse the repository at this point in the history

  3. [ruff F401 #10390 #10391] edit to make imports explicit

    @plredmond
    plredmond committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    2555105 View commit details
    Browse the repository at this point in the history

  4. [ruff F401 #10390 #10391] narrower categories

    @plredmond
    plredmond committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    66d9249 View commit details
    Browse the repository at this point in the history

  5. [ruff F401 #10390 #10391] note some renames that would help with read… 

    …ability; remove unnecessary pattern match
    @plredmond
    plredmond committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    2990bb6 View commit details
    Browse the repository at this point in the history

  6. [ruff F401 #10390 #10391] split import bindings by fix we wish to apply

    @plredmond
    plredmond committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    9b70c3b View commit details
    Browse the repository at this point in the history

  7. [ruff F401 #10390 #10391] tweak "fix_imports"; rename it and only ret… 

    …urn a fix if imports were actually given
    @plredmond
    plredmond committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    0d52dc7 View commit details
    Browse the repository at this point in the history

  8. [ruff F401 #10390 #10391] another "fix_imports" function but this one… 

    … either moves to __all__ or makes imports explicit
    @plredmond
    plredmond committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    55c4906 View commit details
    Browse the repository at this point in the history

  9. [ruff F401 #10390 #10391] generate two fixes (instead of one) for the… 

    … two groups of import statement bindings; then iterate over those bindings and the fix which applies to them
    @plredmond
    plredmond committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    80bbdd4 View commit details
    Browse the repository at this point in the history

  10. [ruff F401 #10390 #10391] remove categorize

    @plredmond
    plredmond committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    a35ca67 View commit details
    Browse the repository at this point in the history

  11. [ruff F401 #10390 #10391] rename/remove/cleanup

    @plredmond
    plredmond committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    f29708f View commit details
    Browse the repository at this point in the history

  12. [ruff F401 #10390 #10391] rename and adjust new "fix_imports" function

    @plredmond
    plredmond committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    a8f5373 View commit details
    Browse the repository at this point in the history

  13. [ruff F401 #10390 #10391] cleanup the other fix-imports function

    @plredmond
    plredmond committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    d666bac View commit details
    Browse the repository at this point in the history

  14. [ruff F401 #10390 #10391] add fixture tests for F401 w/__init__.py; r… 

    …ework after discussion w/zanie
    @plredmond
    plredmond committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    c05285f View commit details
    Browse the repository at this point in the history

  15. [ruff F401 #10390 #10391] clippy

    @plredmond
    plredmond committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    f286764 View commit details
    Browse the repository at this point in the history

  16. [ruff F401 #10390 #10391] move comment about tests

    @plredmond
    plredmond committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    203bf01 View commit details
    Browse the repository at this point in the history

  17. [ruff F401 #10390 #10391] unit tests for make_redundant_alias

    @plredmond
    plredmond committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    bd22137 View commit details
    Browse the repository at this point in the history

  18. [ruff F401 #10390 #10391] cargo insta review

    @plredmond
    plredmond committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    c764517 View commit details
    Browse the repository at this point in the history

  19. [ruff F401 #10390 #10391] rebase and change an argument to an altered… 

    … api
    @plredmond
    plredmond committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    1405bae View commit details
    Browse the repository at this point in the history

  20. [ruff F401 #10390 #10391] ruff format the test fixtures

    @plredmond
    plredmond committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    56bec82 View commit details
    Browse the repository at this point in the history

  21. [ruff F401 #10390 #10391] note that the empty py files are used by a … 

    …test
    @plredmond
    plredmond committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    b827bfc View commit details
    Browse the repository at this point in the history

  22. [ruff F401 #10390 #10391] cargo insta review for the reformatted test… 

    … fixtures
    @plredmond
    plredmond committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    482cb75 View commit details
    Browse the repository at this point in the history

  23. [ruff F401 #10390 #10391] rename loop binding variables

    @plredmond
    plredmond committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    667a901 View commit details
    Browse the repository at this point in the history

  24. [ruff F401 #10390 #10391] flip incorrectly reversed preview-flag-check

    @plredmond
    plredmond committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    c6a3ef4 View commit details
    Browse the repository at this point in the history

  25. [ruff F401 #10390 #10391] restore the old condition used to enable/di… 

    …sable F401 based on deprecated flag, but use the preview flag; move the testcases down to the preview testcase section; move the insta-snapshots to the preview paths
    @plredmond
    plredmond committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    5ead877 View commit details
    Browse the repository at this point in the history

  26. [ruff F401 #10390 #10391] delete the init_unused_import_opt_in_to_fix… 

    … test and add a test-case for the preview linter rules that references that fixture; move its insta-snapshot to the location used by the new test-case
    @plredmond
    plredmond committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    1800eb7 View commit details
    Browse the repository at this point in the history

  27. [ruff F401 #10390 #10391] add information to unused-import-context; u… 

    …pdate generation of help messages
    @plredmond
    plredmond committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    37c5152 View commit details
    Browse the repository at this point in the history

  28. [ruff F401 #10390 #10391] attach context to import-bindings earlier, … 

    …when deciding how to fix them
    @plredmond
    plredmond committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    76608fe View commit details
    Browse the repository at this point in the history

  29. [ruff F401 #10390 #10391] rename to_explicit -> to_reexport

    @plredmond
    plredmond committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    50d37b6 View commit details
    Browse the repository at this point in the history

  30. [ruff F401 #10390 #10391] pass iterators to fix_by_* methods instead … 

    …of slices
    @plredmond
    plredmond committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    130ce57 View commit details
    Browse the repository at this point in the history

  31. [ruff F401 #10390 #10391] better (but not perfect) help text

    @plredmond
    plredmond committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    18c3001 View commit details
    Browse the repository at this point in the history

Commits on May 1, 2024

  1. optimize a shortcircuiting boolean expression per micha 

    Co-authored-by: Micha Reiser <micha@reiser.io>
    @plredmond @MichaReiser
    plredmond and MichaReiser authored May 1, 2024
    Configuration menu
    Copy the full SHA
    53d6807 View commit details
    Browse the repository at this point in the history

  2. use an array instead of a vec per micha 

    Co-authored-by: Micha Reiser <micha@reiser.io>
    @plredmond @MichaReiser
    plredmond and MichaReiser authored May 1, 2024
    Configuration menu
    Copy the full SHA
    c8876b2 View commit details
    Browse the repository at this point in the history

  3. [ruff F401 #10390 #10391] swap arg order; move imports to top level

    @plredmond
    plredmond committed May 1, 2024
    Configuration menu
    Copy the full SHA
    71e191a View commit details
    Browse the repository at this point in the history

  4. correct level to is_first_party

    @plredmond
    plredmond committed May 1, 2024
    Configuration menu
    Copy the full SHA
    dacbe73 View commit details
    Browse the repository at this point in the history

Commits on May 2, 2024

  1. charlie patch to remove the unfinished dunder_all mutation

    @plredmond
    plredmond committed May 2, 2024
    Configuration menu
    Copy the full SHA
    31768b6 View commit details
    Browse the repository at this point in the history