Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respect file exclusions in ruff server #11590

Merged
merged 3 commits into from
May 29, 2024
Merged

Respect file exclusions in ruff server #11590

merged 3 commits into from
May 29, 2024

Conversation

charliermarsh
Copy link
Member

Summary

Closes #11587.

Test Plan

  • Added a lint error to test_server.py in vscode-ruff.
  • Validated that, prior to this change, diagnostics appeared in the file.
  • Validated that, with this change, no diagnostics were shown.
  • Validated that, with this change, no diagnostics were fixed on-save.

@charliermarsh charliermarsh added bug Something isn't working server Related to the LSP server labels May 29, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 29, 2024 •
edited
Loading

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@charliermarsh charliermarsh enabled auto-merge (squash) May 29, 2024 02:55
@charliermarsh charliermarsh merged commit 204c59e into main May 29, 2024
17 checks passed
@charliermarsh charliermarsh deleted the charlie/exclude-lsp branch May 29, 2024 02:58
@BrewTestBot BrewTestBot mentioned this pull request May 31, 2024
Merged
@dhruvmanila dhruvmanila mentioned this pull request Jul 22, 2024
Closed
@messense messense mentioned this pull request Aug 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhruvmanila dhruvmanila dhruvmanila approved these changes

Assignees
No one assigned
Labels
bug Something isn't working server Related to the LSP server
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Server and CLI don' t exclude the same directories
2 participants
@charliermarsh @dhruvmanila