-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rules): detect httpx
for S113
#12174
feat(rules): detect httpx
for S113
#12174
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks -- this looks good to me!
Not sure a missing timeout is a problem since |
httpx has default timeout, this PR would be a false positive https://www.python-httpx.org/advanced/timeouts/
|
Indeed, really sorry for missing that obvious information, I should have better checked that. |
false positive fix #12213 |
Summary
Bandit now also reports
B113
onhttpx
(PyCQA/bandit#1060). This PR implements the same logic, to detect missing orNone
timeouts forhttpx
alongsiderequests
.Test Plan
Snapshot tests.