Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flake8-async] Update ASYNC116 to match upstream #12266

Merged
merged 4 commits into from
Jul 10, 2024

Conversation

augustelalande
Copy link
Contributor

Summary

Update the name of ASYNC116 to match upstream.

Also update the functionality to match upstream by adding support for anyio (gated behind preview). asyncio does not have a sleep_forever equivalent.

Test Plan

Added tests for anyio

Copy link
Member

@charliermarsh charliermarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thanks.

Copy link

codspeed-hq bot commented Jul 10, 2024

CodSpeed Performance Report

Merging #12266 will not alter performance

Comparing augustelalande:async116 (e5b65d8) with main (d365f1a)

Summary

✅ 33 untouched benchmarks

@MichaReiser MichaReiser added the preview Related to preview mode features label Jul 10, 2024
@MichaReiser MichaReiser merged commit 880c31d into astral-sh:main Jul 10, 2024
20 checks passed
@augustelalande augustelalande deleted the async116 branch July 10, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preview Related to preview mode features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants