Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pylint] Implement shallow-copy-environ (W1507) #14241

Merged
merged 6 commits into from
Nov 10, 2024
Merged

[pylint] Implement shallow-copy-environ (W1507) #14241

merged 6 commits into from
Nov 10, 2024
+122 −0

Conversation

harupy
Copy link
Contributor

@harupy harupy commented Nov 10, 2024 •
edited
Loading

Summary

Related to #970. Implement shallow-copy-environ / W1507.

Test Plan

Unit test

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 10, 2024 •
edited
Loading

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

harupy and others added 3 commits November 10, 2024 21:51
@harupy @sbrugman
Apply suggestions from code review
2ed9dd7 
Co-authored-by: Simon Brugman <sbrugman@users.noreply.github.com>
@charliermarsh
Nits
a020eed
@charliermarsh
Preview
2bf945d
charliermarsh
charliermarsh approved these changes Nov 10, 2024
View reviewed changes
Copy link
Member

@charliermarsh charliermarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@charliermarsh charliermarsh added rule Implementing or modifying a lint rule preview Related to preview mode features labels Nov 10, 2024
@charliermarsh charliermarsh enabled auto-merge (squash) November 10, 2024 22:53
@charliermarsh charliermarsh merged commit d4cf61d into astral-sh:main Nov 10, 2024
19 checks passed
@harupy harupy deleted the shallow-copy-environ branch November 11, 2024 00:39
@dhruvmanila dhruvmanila changed the title Implement shallow-copy-environ / W1507 [pylint] Implement shallow-copy-environ (W1507) Nov 15, 2024
@BrewTestBot BrewTestBot mentioned this pull request Nov 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbrugman sbrugman sbrugman left review comments

@charliermarsh charliermarsh charliermarsh approved these changes

Assignees
No one assigned
Labels
preview Related to preview mode features rule Implementing or modifying a lint rule
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@harupy @charliermarsh @sbrugman