From 335ec4225ad7ffbd74da1c310f7b27efb31a5971 Mon Sep 17 00:00:00 2001 From: Zanie Date: Fri, 20 Oct 2023 11:41:16 -0500 Subject: [PATCH] Update fix for `literal-membership` (`PLR6201`) to be unsafe --- .../src/rules/pylint/rules/literal_membership.rs | 5 ++++- ...rules__pylint__tests__PLR6201_literal_membership.py.snap | 6 +++--- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/crates/ruff_linter/src/rules/pylint/rules/literal_membership.rs b/crates/ruff_linter/src/rules/pylint/rules/literal_membership.rs index e69a09c916067..44dbe31dfa8ef 100644 --- a/crates/ruff_linter/src/rules/pylint/rules/literal_membership.rs +++ b/crates/ruff_linter/src/rules/pylint/rules/literal_membership.rs @@ -59,7 +59,10 @@ pub(crate) fn literal_membership(checker: &mut Checker, compare: &ast::ExprCompa let literal = checker.locator().slice(right); let set = format!("{{{}}}", &literal[1..literal.len() - 1]); - diagnostic.set_fix(Fix::safe_edit(Edit::range_replacement(set, right.range()))); + diagnostic.set_fix(Fix::unsafe_edit(Edit::range_replacement( + set, + right.range(), + ))); checker.diagnostics.push(diagnostic); } diff --git a/crates/ruff_linter/src/rules/pylint/snapshots/ruff_linter__rules__pylint__tests__PLR6201_literal_membership.py.snap b/crates/ruff_linter/src/rules/pylint/snapshots/ruff_linter__rules__pylint__tests__PLR6201_literal_membership.py.snap index bb3c795519038..94506940a6be6 100644 --- a/crates/ruff_linter/src/rules/pylint/snapshots/ruff_linter__rules__pylint__tests__PLR6201_literal_membership.py.snap +++ b/crates/ruff_linter/src/rules/pylint/snapshots/ruff_linter__rules__pylint__tests__PLR6201_literal_membership.py.snap @@ -11,7 +11,7 @@ literal_membership.py:2:6: PLR6201 [*] Use a `set` literal when testing for memb | = help: Convert to `set` -ℹ Fix +ℹ Suggested fix 1 1 | # Errors 2 |-1 in [1, 2, 3] 2 |+1 in {1, 2, 3} @@ -30,7 +30,7 @@ literal_membership.py:3:6: PLR6201 [*] Use a `set` literal when testing for memb | = help: Convert to `set` -ℹ Fix +ℹ Suggested fix 1 1 | # Errors 2 2 | 1 in [1, 2, 3] 3 |-1 in (1, 2, 3) @@ -53,7 +53,7 @@ literal_membership.py:4:6: PLR6201 [*] Use a `set` literal when testing for memb | = help: Convert to `set` -ℹ Fix +ℹ Suggested fix 1 1 | # Errors 2 2 | 1 in [1, 2, 3] 3 3 | 1 in (1, 2, 3)