Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use comment_ranges for isort directive extraction #9414

Merged
merged 1 commit into from
Jan 6, 2024
Merged

Use comment_ranges for isort directive extraction #9414

merged 1 commit into from
Jan 6, 2024

Conversation

charliermarsh
Copy link
Member

Summary

No need to iterate over the token stream to find comments -- we already know where they are.

@charliermarsh charliermarsh added the performance Potential performance improvement label Jan 6, 2024
@charliermarsh charliermarsh changed the title Use comment_ranges for isort directive extraction Use comment_ranges for isort directive extraction Jan 6, 2024
@charliermarsh charliermarsh merged commit f684175 into main Jan 6, 2024
17 checks passed
@charliermarsh charliermarsh deleted the charlie/offset branch January 6, 2024 21:05
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 6, 2024

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@Porkepix Porkepix mentioned this pull request Jan 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
performance Potential performance improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@charliermarsh