From 102845d779affaab05dce9a093cd99d8aecd1840 Mon Sep 17 00:00:00 2001 From: Adrien Ball Date: Thu, 15 Feb 2024 11:43:41 +0100 Subject: [PATCH] Fix SIM113 false positive with async for loops --- .../resources/test/fixtures/flake8_simplify/SIM113.py | 8 ++++++++ .../src/rules/flake8_simplify/rules/enumerate_for_loop.rs | 5 +++++ 2 files changed, 13 insertions(+) diff --git a/crates/ruff_linter/resources/test/fixtures/flake8_simplify/SIM113.py b/crates/ruff_linter/resources/test/fixtures/flake8_simplify/SIM113.py index 44cb92b3a3db2..e0ac4190edcf0 100644 --- a/crates/ruff_linter/resources/test/fixtures/flake8_simplify/SIM113.py +++ b/crates/ruff_linter/resources/test/fixtures/flake8_simplify/SIM113.py @@ -193,3 +193,11 @@ def inner(): for y in range(5): g(x, idx) idx += 1 + +async def func(): + # OK (for loop is async) + idx = 0 + + async for x in async_gen(): + g(x, idx) + idx += 1 diff --git a/crates/ruff_linter/src/rules/flake8_simplify/rules/enumerate_for_loop.rs b/crates/ruff_linter/src/rules/flake8_simplify/rules/enumerate_for_loop.rs index 8c8103c7c8ebf..03fc7b09f494f 100644 --- a/crates/ruff_linter/src/rules/flake8_simplify/rules/enumerate_for_loop.rs +++ b/crates/ruff_linter/src/rules/flake8_simplify/rules/enumerate_for_loop.rs @@ -49,6 +49,11 @@ impl Violation for EnumerateForLoop { /// SIM113 pub(crate) fn enumerate_for_loop(checker: &mut Checker, for_stmt: &ast::StmtFor) { + // If the loop is async, abort. + if for_stmt.is_async { + return; + } + // If the loop contains a `continue`, abort. let mut visitor = LoopControlFlowVisitor::default(); visitor.visit_body(&for_stmt.body);