Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit does not include check for new extras #1948

Closed
zanieb opened this issue Feb 24, 2024 · 4 comments
Closed

Audit does not include check for new extras #1948

zanieb opened this issue Feb 24, 2024 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@zanieb
Copy link
Member

zanieb commented Feb 24, 2024

Adding an extra does not update the package without --upgrade, e.g.

❯ uv pip install packse
...
❯ packse index up
Using index commands requires installation with extra 'index'.
❯ uv pip install "packse[index]"
Audited 1 package in 10ms
❯ uv pip install "packse[index]" --upgrade
Resolved 33 packages in 368ms
Downloaded 1 package in 102ms
Installed 1 package in 13ms
 + pypiserver==2.0.1

If feasible, we should include this in audits.

@zanieb zanieb added the bug Something isn't working label Feb 24, 2024
@zanieb zanieb changed the title Audit does not include checking for extras Audit does not include check for new extras Feb 24, 2024
@charliermarsh charliermarsh self-assigned this Feb 24, 2024
@skshetry
Copy link
Contributor

Maybe #1651 is also related?

It does not pick any new dependencies, on either editable or non-editable installs.

uv pip install "."
Audited 1 package in 2ms

But the --upgrade works.

@charliermarsh
Copy link
Member

I think editable are slightly different, but I’ll be looking into both this weekend or early next week.

@charliermarsh
Copy link
Member

I'm unable to reproduce this. Is it possible you're on an older version? (We did fix this in #1727.)

@zanieb
Copy link
Member Author

zanieb commented Feb 24, 2024

Yep older version — sorry so many shims around.

@zanieb zanieb closed this as completed Feb 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants