Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

universal-lock: check that markers are disjoint before forking #3926

Closed
Tracked by #3350
BurntSushi opened this issue May 30, 2024 · 1 comment · Fixed by #4135
Closed
Tracked by #3350

universal-lock: check that markers are disjoint before forking #3926

BurntSushi opened this issue May 30, 2024 · 1 comment · Fixed by #4135
Assignees
Labels
internal A refactor or improvement that is not user-facing

Comments

@BurntSushi
Copy link
Member

In #3831, I decided to punt on checking whether markers were disjoint before forking the resolver. But we need to do this for correctness. Namely, if we fork because two different dependency specifications reference the same package but their markers are not disjoint, then we could wind up in a situation where two different versions of the same package would be installed according to the lock file. Which, of course, we cannot do. So we can only permit forking when marker expressions are completely disjoint, thus guaranteeing that only one version will be selected at install time.

@BurntSushi BurntSushi added the internal A refactor or improvement that is not user-facing label May 30, 2024
@BurntSushi BurntSushi self-assigned this May 30, 2024
@BurntSushi
Copy link
Member Author

Closed by #4135

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal A refactor or improvement that is not user-facing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant