Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new INSTALLER and REQUESTED files are chmod 600 #5435

Closed
AtomBaf opened this issue Jul 25, 2024 · 6 comments · Fixed by #5457
Closed

new INSTALLER and REQUESTED files are chmod 600 #5435

AtomBaf opened this issue Jul 25, 2024 · 6 comments · Fixed by #5457
Assignees
Labels
bug Something isn't working compatibility Compatibility with a specification or another tool

Comments

@AtomBaf
Copy link

AtomBaf commented Jul 25, 2024

Since recently, I noticed that the uv pip install command will add 2 files in the metadata directory of an installed package: INSTALLER and REQUESTED.

These files were not there in previous uv versions, I don't know however when it was introduced but I can tell that this was not the case in version 0.2.2.
Now with the current version 0.2.28 these files are there. My problem is that their mod is 600 instead of a more usual 644 for other files in the same directory (like METADATAor WHEEL).
This causes a problem on my stack since for other reasons I install the package with one user, and another user read the libs metadata for some checks.

edit: related commit: https://github.com/astral-sh/uv/pull/337/files#diff-c1686969b46b2c133e184a8c25069ada51363d91354e35fac208bb67239fcf2cL813

@charliermarsh charliermarsh added the compatibility Compatibility with a specification or another tool label Jul 25, 2024
@charliermarsh
Copy link
Member

Interesting, thanks.

@charliermarsh
Copy link
Member

What operating system are you on?

@charliermarsh
Copy link
Member

Interesting, ok, this changed because we initially create the file in a temporary directory, then move it over (to avoid partial writes), and by default that uses 600: https://docs.rs/tempfile/latest/tempfile/struct.Builder.html#method.permissions

@zanieb zanieb added the bug Something isn't working label Jul 25, 2024
@charliermarsh charliermarsh self-assigned this Jul 25, 2024
@charliermarsh
Copy link
Member

I'm surprised we don't see this in more places?

@AtomBaf
Copy link
Author

AtomBaf commented Jul 25, 2024

Sorry, my OS is Rocky Linux 9.3.

And I think what I'm doing should not happen often since reading all the files including these 2 files is not what python will typically do. This is probably why I'm the first to report this.

@charliermarsh
Copy link
Member

No worries. You're right that the permissions should be changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working compatibility Compatibility with a specification or another tool
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants