Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show ephemeral progress bar in uv run and uv tool run #5758

Closed
charliermarsh opened this issue Aug 4, 2024 · 4 comments · Fixed by #5899
Closed

Show ephemeral progress bar in uv run and uv tool run #5758

charliermarsh opened this issue Aug 4, 2024 · 4 comments · Fixed by #5899
Assignees
Labels
cli Related to the command line interface preview Experimental behavior

Comments

@charliermarsh
Copy link
Member

When the environment isn't cached / readily available, I think these now show too little logging (for large environments, it feels like it's just hanging, when in reality it's preparing the environment). We should just show a spinner in those cases at least.

@charliermarsh charliermarsh added cli Related to the command line interface preview Experimental behavior labels Aug 4, 2024
@zanieb
Copy link
Member

zanieb commented Aug 5, 2024

I guess cargo run isn't quiet by default, maybe we should reconsider? We should definitely show if we need to build the root project.

@charliermarsh
Copy link
Member Author

charliermarsh commented Aug 5, 2024

Yeah it's too quiet right now... Some ideas (not mutually exclusive):

  • Show an ephemeral spinner (so, it disappears once complete) if we have to do any work? Unfortunately we might have to "always" show this for uv tool run because (if the tool isn't already-installed) we have to perform a resolution even if we end up using a cached environment.
  • Show the "Building" and "Built" outputs always? Like the cyan and green ones that appear separately from the progress spinners.
  • Show the "Installed X packages in Yms" output but not the full list of modifications?

@charliermarsh charliermarsh self-assigned this Aug 5, 2024
@konstin
Copy link
Member

konstin commented Aug 6, 2024

Personally, i'd like uv run to be completely if everything is cached (i do cargo run -q often enough), show a spinner if something isn't and Building/Built/Installed X packages in Yms summary messages if something changes (but not the whole list of packages).

@charliermarsh
Copy link
Member Author

I agree. The main problem there is that with uv tool run, we have to resolve in order to locate a cached environment 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli Related to the command line interface preview Experimental behavior
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants