Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check { workspace = true, editable = false } support #5958

Closed
konstin opened this issue Aug 9, 2024 · 4 comments · Fixed by #5987
Closed

Check { workspace = true, editable = false } support #5958

konstin opened this issue Aug 9, 2024 · 4 comments · Fixed by #5987
Assignees
Labels
preview Experimental behavior

Comments

@konstin
Copy link
Member

konstin commented Aug 9, 2024

We need to check the support of non-editable workspace dependencies in pyproject.toml. If it doesn't work remove it from the docs.

See also #5792.

@konstin konstin added the preview Experimental behavior label Aug 9, 2024
@charliermarsh
Copy link
Member

I've confirmed that this isn't supported. The issue is that we have to lock the entire workspace. So we add all the members (as editable), then lock, then install the appropriate subset.

In order to support this, I think we'd need to make editable part of dependencies, rather than its own source... Since we'd need the workspace member to be a directory that can either be installed as editable or non-editable.

@charliermarsh
Copy link
Member

Do we want to support or remove? \cc @zanieb

@zanieb
Copy link
Member

zanieb commented Aug 9, 2024

I guess we should remove it for now.

@charliermarsh
Copy link
Member

I think I should make a timeboxed effort to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preview Experimental behavior
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants