Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sequencer: make fee change testing easier to debug #1715

Open
ethanoroshiba opened this issue Oct 22, 2024 · 1 comment · May be fixed by #1811
Open

sequencer: make fee change testing easier to debug #1715

ethanoroshiba opened this issue Oct 22, 2024 · 1 comment · May be fixed by #1811
Assignees
@ethanoroshiba
Labels
code-quality sequencer pertaining to the astria-sequencer crate

Comments

@ethanoroshiba
Copy link
Contributor

ethanoroshiba commented Oct 22, 2024 •
edited
Loading

As mentioned here, this macro will be difficult to debug, so we should replace it.

┆Issue Number: ENG-944
@ethanoroshiba ethanoroshiba added sequencer pertaining to the astria-sequencer crate code-quality labels Oct 22, 2024
@ethanoroshiba ethanoroshiba changed the title make fee change testing macro easier to debug sequencer: make fee change testing macro easier to debug Oct 22, 2024
@ethanoroshiba ethanoroshiba mentioned this issue Oct 22, 2024
Merged
@ethanoroshiba ethanoroshiba self-assigned this Oct 22, 2024
@SuperFluffy
Copy link
Member

The macro itself will be impossible to debug because the error message will point to a line of code that doesn't exist/only exists after expansion.

The fix is not to fix the macro but to replace it.

@ethanoroshiba ethanoroshiba changed the title sequencer: make fee change testing macro easier to debug sequencer: make fee change testing easier to debug Oct 23, 2024
This was referenced Oct 23, 2024
Closed
Closed
@Fraser999 Fraser999 linked a pull request Nov 13, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ethanoroshiba ethanoroshiba

Labels
code-quality sequencer pertaining to the astria-sequencer crate
Projects
None yet
Milestone
No milestone
2 participants
@SuperFluffy @ethanoroshiba