feat(protos): add auction result to bundle protos #1795
Conversation
itamarreif
force-pushed
the
itamarreif/auctioneer/eng-998
branch
from
da3b5f5
to
c00046b
Compare
itamarreif
force-pushed
the
itamarreif/auctioneer/eng-998
branch
from
c00046b
to
e50a5a0
Compare
itamarreif
force-pushed
the
itamarreif/auctioneer/eng-998
branch
from
e50a5a0
to
a2643ed
Compare
itamarreif
changed the base branch from
main
to
itamarreif/auctioneer/protos-v1-update
| // The rollup will verify the signature and public key against its configuration, | ||
| // then unbundle the body into rollup transactions and execute them first in the | ||
| // block. | ||
| message AuctionResult { |
There was a problem hiding this comment.
I have to walk back my suggestion for calling this a Result because it would clash with a regular Rust Result: Result<AuctionResult, E>.
Let's go with WinningBundle instead?
There was a problem hiding this comment.
I think it's probably fine to just call this a SignedBundle? That's what it is and provides a more generic option. IE this could allow it to be a bundle generated and signed by a TEE and submitted.
The fact that this signer indicates it is a Auction Result bundle is an implementation detail for the rollup?
There was a problem hiding this comment.
After discussion online, I'm ok with allocation.
Long term we will want something generic for signed data probably.
itamarreif
force-pushed
the
itamarreif/auctioneer/eng-998
branch
from
a2643ed
to
d9eb0ab
Compare
itamarreif
force-pushed
the
itamarreif/auctioneer/protos-v1-update
branch
from
d1edce9
to
4287b94
Compare
itamarreif
force-pushed
the
itamarreif/auctioneer/eng-998
branch
from
d9eb0ab
to
b9bf28c
Compare
|
Changed the name of the envelope type to |
| // rollup. | ||
| bytes public_key = 2; | ||
| // The bundle that was allocated the winning slot by the Auctioneer. | ||
| Bundle payload = 3; |
There was a problem hiding this comment.
I think we want to follow sequencer's Transaction and make this an opaque Any type so that we need not worry about differences in protobuf encoders.
Summary
This PR adds the auction result definition to the bundle api protos.
Background
The auctioneer chooses a winning bundle which it needs to submit in a
RollupDataSubmissionto the sequencer. The winning bundle needs to be signed first, and this PR adds a wrapper object that includes the signature and public key required to verify the signature was done by the correct Auctioneer.Changes
AuctionResultdefintion to the bundle apiChangelogs
AuctionResultdefinition to the bundle api protosRelated Issues
closes #1790