Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename and refactor begin_block and end_block #1809

Open
Tracked by #1810
ethanoroshiba opened this issue Nov 12, 2024 · 0 comments
Open
Tracked by #1810

rename and refactor begin_block and end_block #1809

ethanoroshiba opened this issue Nov 12, 2024 · 0 comments
Assignees
@ethanoroshiba
Labels
code-quality sequencer pertaining to the astria-sequencer crate

Comments

@ethanoroshiba
Copy link
Contributor

ethanoroshiba commented Nov 12, 2024 •
edited by sync-by-unito bot
Loading

Both the Component trait and App have methods called begin_block and end_block. In addition to this, the corresponding, deprecated ABCI structs are needlessly passed through as arguments to these. These methods are no longer present in ABCI as of CometBFT v0.38, so we should rename them and refactor such that we aren't passing objects which have nothing done with them.

┆Issue Number: ENG-1006
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ethanoroshiba ethanoroshiba

Labels
code-quality sequencer pertaining to the astria-sequencer crate
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ethanoroshiba