Add black box tests to composer to cover deleted internal tests #1652
Comments
|
This issue is stale because it has been open 45 days with no activity. Remove stale label or this issue |
github-merge-queue bot
pushed a commit
that referenced
this issue
Jan 22, 2025
## Summary Added blackbox tests to cover whitebox tests which were removed in #1643. ## Background Tests were removed in #1643 because the internal tests were very whitebox-y and fragile. They have not yet been added back as blackbox tests. ## Changes - Added 3 new blackbox tests to cover `bundle_triggered_by_block_timer`, `two_seq_actions_single_bundle`, and `chain_id_mismatch_returns_error`. - Removed old internal tests. ## Testing Passing all tests ## Changelogs No updates required. ## Related Issues closes #1652 --------- Co-authored-by: Fraser Hutchison <190532+Fraser999@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
PR #1643 removes fragile tests that were internal to the
composercrate as they were a maintenance burden.The tests that are removed:
full_bundle- This is covered by the unit tests in thebundle_factorymodule internal to thecomposer. Probably doesn't require adding a new black box test.bundle_triggered_by_block_timer- This test assumes quite a bit of knowledge about the internal functions of the composer (specifically that if the bundle isn't filled then it will be submitted after the block timer).two_seq_actions_single_bundle- A test similar to the existing single_rollup_tx_payload_integrity that has two transactions should be added to cover this.chain_id_mismatch_returns_error- Likely requires bubbling errors up and out from the composer service.┆Issue Number: ENG-914
The text was updated successfully, but these errors were encountered: