Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix page overrides #154

Open
BryceRussell opened this issue Jul 23, 2024 · 0 comments
Open

Fix page overrides #154

BryceRussell opened this issue Jul 23, 2024 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed todo Goal for next major release

Comments

@BryceRussell
Copy link
Member

@altsalt Reported that using a configuration like:

pages: {
	'/[...slug]': '/pages/[...slug]',
},

Throws the error: [AstroUserError] Invalid page override, pattern must contain the same params in the same location

This is an issue with the way route patterns are validated: https://github.com/astrolicious/astro-theme-provider/blob/main/package/src/utils/path.ts#L43-L52
@BryceRussell BryceRussell added bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers todo Goal for next major release labels Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed todo Goal for next major release
Projects
Astro Theme Provider Roadmap
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
1 participant
@BryceRussell