Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify the manifest.json #1407

Open
pankajastro opened this issue Dec 18, 2024 · 1 comment
Open

Unify the manifest.json #1407

pankajastro opened this issue Dec 18, 2024 · 1 comment
Labels
good first issue Good for newcomers parsing:dbt_manifest Issues, questions, or features related to dbt_manifest parsing

Comments

@pankajastro
Copy link
Contributor

pankajastro commented Dec 18, 2024 •
edited
Loading

Currently, we have checked in manifest.json at multiple places example

https://github.com/astronomer/astronomer-cosmos/blob/main/tests/sample/manifest_source.json
https://github.com/astronomer/astronomer-cosmos/blob/main/dev/dags/dbt/jaffle_shop/target/manifest.json

As a result, many times, both files diverge and result in unexpected results during the test.

For example, we have test https://github.com/astronomer/astronomer-cosmos/blob/0edb07d6b58827ebf66fbc82a062ea0a5cfb0717/tests/dbt/test_graph.py#L614 which run for dbt ls and manifest and in both cases it uses different manifest file and it results in unexpected failure because manifest_source.json is not latest.
@pankajastro pankajastro mentioned this issue Dec 18, 2024
Merged
@dosubot dosubot bot added the parsing:dbt_manifest Issues, questions, or features related to dbt_manifest parsing label Dec 18, 2024
@github-actions GitHub Actions
Copy link

This issue is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Issue has not had recent activity or appears to be solved. Stale issues will be automatically closed label Jan 18, 2025
@tatiana tatiana added the good first issue Good for newcomers label Feb 3, 2025
@github-actions github-actions bot removed the stale Issue has not had recent activity or appears to be solved. Stale issues will be automatically closed label Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers parsing:dbt_manifest Issues, questions, or features related to dbt_manifest parsing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tatiana @pankajastro