-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add overlap option for cone search #67
Comments
I agree with this - I would maybe call the options Implementation-wise, doing it in |
+1 for using 'center' and 'any', sounds easier to understand to me |
Agreed that "full" was a complete misnomer and that
Agreed. I'll try to find time to make a pull request later this week. |
Discussed at astropy coordination meeting in Tucson. 👍 from @taldcroft and @adrn. |
In Gammapy we currently call healpy.query_disc with both the
inclusive=True
and theinclusive=False
option (see gammapy/gammapy#1167 (comment)).As discussed in #41 , probably we don't want to spend the time to fully implement
healpy.query_disc
concerning theinclusive=False
behaviour.But maybe we could add an option to HEALPix.cone_search_lonlat that corresponds to the
inclusive=True
behaviour, i.e. restricts the pixels to the ones where the center is in the cone?@astrofrog - OK to add this?
How about calling it
overlap={'center', 'full'}
which is maybe a bit more intuitive thaninclusive = {True, False}
and also more extensible should we want to add other options in the future?Concerning implementation: should it just be done at the end of the function in an
if overlap == 'center'
block using a Numpy expression, subsetting with a mask that's true if the pixel center is in the cone? Or would you suggest this be added in the C or Cython code somehow?The text was updated successfully, but these errors were encountered: