Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is the E-term correction in PyAST and SLALIB the 'reference' implementation? #20

Open
astrofrog opened this issue Dec 15, 2012 · 2 comments

Comments

@astrofrog
Copy link
Member

This is a question for @timj, @dsberry, and @scottransom - digging into the SLALIB source code (which I think AST relies on for the actual transformations?) it looks like the correction for the e-terms of aberration is linear in time. However, the Explanatory Supplement to the Astronomical Almanac suggests a 3rd order polynomial correction, which Kapteyn (and Astropy, in #551) implement. Should the version in SLALIB be updated, or is there a good reason for keeping it the way it is? (just trying to understand whether I should be using AST as a reference for conversions involving FK4 with the correction applied.

@timj
Copy link
Contributor

timj commented Dec 15, 2012

AST relies on PAL which relies on SOFA and a port of the Fortran SLA to C. The e-terms code is therefore identical to the SLA code. The SLA code cites Smith, C.A. et al., 1989. Astr.J. 97, 265 and Yallop, B.D. et al., 1989. Astr.J. 97, 274. Pat Wallace is probably the person to ask rather than us.

@eteq
Copy link
Member

eteq commented Dec 19, 2012

@astrofrog - did you get a resolution to this? Is this just a matter of the explanatory supplement suggesting a higher-order approximation to the Earth's orbit, or is there actually an official "right" answer?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants