Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SE++ 0.17 runs in circles #442

Closed
mkuemmel opened this issue Jan 30, 2022 · 4 comments
Closed

SE++ 0.17 runs in circles #442

mkuemmel opened this issue Jan 30, 2022 · 4 comments
Labels

Comments

@mkuemmel
Copy link
Collaborator

I found another case where SE++ runs in circles doing nothing. The full dataset is available here (280MB):
https://we.tl/t-dbmTeDzXxl

The catch is the python config file asks for Sersic fit, but the only measurement image does not have PSF specified. Also the ASCII config file has no PSF, hence SE++ runs in circles.

Giving a PSF in the config file "psf-filename=...", "psf-pixel-sampling=..." or likely giving a PSF with the image solves the problem.

Should either ask for a PSF or at least give an error.

No big deal, but....

@mkuemmel mkuemmel added the bug label Jan 30, 2022
@ayllon
Copy link
Member

ayllon commented Feb 3, 2022

Probably related to #438. My guess is that an exception is thrown and the thread pool does not recover properly from it.
Let me check.

@mkuemmel
Copy link
Collaborator Author

mkuemmel commented Feb 3, 2022

Well, #438 appeared to be solved with Marc's commit. Do you think that was only kind of accidental?

@ayllon
Copy link
Member

ayllon commented Feb 3, 2022

No, not at all. The exception itself was fixed, but the problem with handling exceptions may still be there. I think the thread pool fails to finish gracefully when threads start dying and just hangs.

@mkuemmel
Copy link
Collaborator Author

That version is no longer relevant and the recent v0.21 does not show this behaviour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants