fix: update npm to latest for windows #1553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Souvikns
requested review from
Amzani,
Shurtu-gal and
asyncapi-bot-eve
as code owners
Shurtu-gal
approved these changes
Oct 22, 2024
|
/rtm |
|
🎉 This PR is included in version 2.7.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Souvikns
added a commit
to Souvikns/cli
that referenced
this pull request
Oct 22, 2024
* chore: update package-lock.json * fix: add package-lock.json (asyncapi#1542) * chore: migrate github-action to cli (asyncapi#1487) * New Github action added for cli * Added new files in the github-action * removed monorepo style for github action * Updated github action with Dockerfile changes * added command to pack cli for linux, docker build command * added test-workflow for github-action * chore: fix docker context * chore: change docker context * fix: dockerfile * changed dockerfile * fix: dockerfile * Converted Dockerfile into multi stages * added github-action folder * added assets folder to github action image * deleted act file script * removed asyncapi.yaml file from .gitignore * corrected output file for workflow * updated Dockerfile * added bundle file * changed bundle files * Updated README * updated output bundle directory --------- Co-authored-by: asyncapi-bot <bot+chan@asyncapi.io> Co-authored-by: Ashish Padhy <100484401+Shurtu-gal@users.noreply.github.com> * feat: update oclif to v4 (asyncapi#1546) * feat: update oclif to v4 * chore: removed unused dependencies * Update myhook.ts * chore: update package-lock.json version (asyncapi#1550) * fix: add description for the start command in AsyncAPI CLI (asyncapi#1534) (asyncapi#1537) Co-authored-by: Ashish Padhy <100484401+Shurtu-gal@users.noreply.github.com> * chore(release): v2.7.1 (asyncapi#1551) * fix: update npm to latest for windows (asyncapi#1553) * chore(release): v2.7.2 (asyncapi#1554) * Update upload-release-assets.yml --------- Co-authored-by: root <root@LAPTOP-K7PL9FIU> Co-authored-by: Ashish Padhy <100484401+Shurtu-gal@users.noreply.github.com> Co-authored-by: Akshat Nema <76521428+akshatnema@users.noreply.github.com> Co-authored-by: asyncapi-bot <bot+chan@asyncapi.io> Co-authored-by: Taufiq Hassan <145540627+toffee-k21@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There was a issue with windows, release as it needed nodejs v20+ to generate assets. https://github.com/asyncapi/cli/actions/runs/11427592031/job/31791892874. In this PR I am updating the workflow to use latest npm version.