Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: exclude .all-contributorsrc from test workflow triggers #1356

Closed
wants to merge 21 commits into from

Conversation

AdityaP700
Copy link
Contributor

Description

  • Added .all-contributorsrc to the paths exclusion list in the test workflow to prevent unnecessary test runs when only contributor list is updated

Copy link

changeset-bot bot commented Feb 5, 2025

⚠️ No Changeset found

Latest commit: 9e010eb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@derberg
Copy link
Member

derberg commented Feb 5, 2025

@AdityaP700 I think you committed wrong thing. I suggest each PR you always make from new branch otherwise it remembers old commits and causes issues

Copy link

sonarqubecloud bot commented Feb 5, 2025

@AdityaP700
Copy link
Contributor Author

AdityaP700 commented Feb 5, 2025

@derberg my bad ,this was a negligence from my side ,i will surely keep in mind from the very next time !!

@derberg
Copy link
Member

derberg commented Feb 5, 2025

this PR still contains wrong things, please review PR also after pushing

@AdityaP700 AdityaP700 closed this Feb 5, 2025
@derberg
Copy link
Member

derberg commented Feb 6, 2025

@AdityaP700 working on new one?

@AdityaP700
Copy link
Contributor Author

@AdityaP700 working on new one?

I would be frank ,i did worked on it by adding the .all-contributorsrc in the ignored list but while testing it locally ,i wasn't getting the result so that's how it went.

Copy link
Member

derberg commented Feb 6, 2025

sorry, didn't get it? you mean you will not work on a new PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants