-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update template to work with @asyncapi/parser 2.x #272
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
@ivankahl I update PR title (must start lower case). Please update snapshots for tests, as template code changed |
Kudos, SonarCloud Quality Gate passed! |
Sure thing @derberg, I've updated the snapshot and the tests pass:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
/rtm |
🎉 This PR is included in version 0.9.32 🎉 The release is available on: Your semantic-release bot 📦🚀 |
@allcontributors please add @ivankahl for code, test |
I've put up a pull request to add @ivankahl! 🎉 |
Description
Tests
I updated the test snapshot as the template change. See integration test results below:
I tested the template by using it for my own project and checking the application runs and the WebSocket works. Please see test results below:
Proof that the WebSocket connection works:
Related issue(s)
Resolves #271