Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add migration guides #106

Closed
jonaslagoni opened this issue Nov 30, 2023 · 10 comments
Closed

Add migration guides #106

jonaslagoni opened this issue Nov 30, 2023 · 10 comments
Labels
📑 docs enhancement New feature or request good first issue Good for newcomers

Comments

@jonaslagoni
Copy link
Member

Reason/Context

Currently, we have no docs that describe the migration guide between versions, we should add them.

This can be done by checking the commit history and looking for commits with !: i.e. feat!:, that describes a breaking change.

@jonaslagoni jonaslagoni added enhancement New feature or request good first issue Good for newcomers 📑 docs labels Nov 30, 2023
@jonaslagoni
Copy link
Member Author

Here is the TLDR:

Message

- - messageId(): `string` | `undefined`
- - schemaFormat(): `string`
+ - schemaFormat(): `string` | `undefined`

MessageTrait

- - messageId(): `string` | `undefined`
- - schemaFormat(): `string`
+ - schemaFormat(): `string` | `undefined`

for messageId use id instead.

@Ibukun-tech
Copy link

what is the meaning of TLDR?

@jonaslagoni
Copy link
Member Author

It's just the short answer to the changes that were between the two versions of v2 and v3 of the parser.

messageId got removed, and should use id instead, schemaFormat changed return types.

@Ibukun-tech
Copy link

can I be assigned to this

@Ibukun-tech
Copy link

@jonaslagoni

@jonaslagoni
Copy link
Member Author

We got no assignments, just say you are working on it and that's it 👍

@Ibukun-tech
Copy link

I am working on this

@Ibukun-tech
Copy link

can this be changed to hasMessageId() to hasId()

@RegretfulWinter
Copy link
Contributor

RegretfulWinter commented Feb 19, 2024

Hi @jonaslagoni, I'm Jiehui Ma (Claudia), a newcomer to AsyncAPI community. I came across this good first issue and based on the TLDR I made a draft version of the migration guide specially for Parser in this PR.

Looking forward to any feedbacks on the wording as well as format! Also if there are anything incorrectly documented, please let me know, I will improve it immediately.

Also, I am not sure if creating the migration document inside this repository is the ideal practice. Shall we integrate it into the main migration guide?

cc @Ibukun-tech also open to discussion so that we can work on together to make the document better!

@Ibukun-tech
Copy link

@RegretfulWinter lets work on this together

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📑 docs enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants