-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add migration guides #106
Comments
Here is the TLDR: Message- - messageId(): `string` | `undefined`
- - schemaFormat(): `string`
+ - schemaFormat(): `string` | `undefined` MessageTrait- - messageId(): `string` | `undefined`
- - schemaFormat(): `string`
+ - schemaFormat(): `string` | `undefined` for |
what is the meaning of TLDR? |
It's just the short answer to the changes that were between the two versions of v2 and v3 of the parser.
|
can I be assigned to this |
We got no assignments, just say you are working on it and that's it 👍 |
I am working on this |
can this be changed to hasMessageId() to hasId() |
Hi @jonaslagoni, I'm Jiehui Ma (Claudia), a newcomer to AsyncAPI community. I came across this good first issue and based on the TLDR I made a draft version of the migration guide specially for Parser in this PR. Looking forward to any feedbacks on the wording as well as format! Also if there are anything incorrectly documented, please let me know, I will improve it immediately. Also, I am not sure if creating the migration document inside this repository is the ideal practice. Shall we integrate it into the main migration guide? cc @Ibukun-tech also open to discussion so that we can work on together to make the document better! |
@RegretfulWinter lets work on this together |
Reason/Context
Currently, we have no docs that describe the migration guide between versions, we should add them.
This can be done by checking the commit history and looking for commits with
!:
i.e.feat!:
, that describes a breaking change.The text was updated successfully, but these errors were encountered: