Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: merge next-major-spec with latest master #807

Merged
merged 3 commits into from
Jun 15, 2022
Merged

chore: merge next-major-spec with latest master #807

merged 3 commits into from
Jun 15, 2022

Conversation

fmvilas
Copy link
Member

@fmvilas fmvilas commented Jun 13, 2022 •
edited
Loading

Merge next-major-spec with latest master

jonaslagoni
jonaslagoni approved these changes Jun 13, 2022
View reviewed changes
Copy link
Member

@jonaslagoni jonaslagoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jonaslagoni
Copy link
Member

Ahh, it had conflicts, thats why it did not auto update: #759

@fmvilas
Copy link
Member Author

fmvilas commented Jun 13, 2022

Yup. Moving this convo to #759.

@fmvilas fmvilas mentioned this pull request Jun 13, 2022
Merged
1 task
@fmvilas fmvilas changed the title feat: merge with latest master feat: merge next-major-spec with latest master Jun 13, 2022
@fmvilas fmvilas changed the title feat: merge next-major-spec with latest master chore: merge next-major-spec with latest master Jun 13, 2022
@derberg
Copy link
Member

derberg commented Jun 14, 2022

@fmvilas did you check failing checks?

@fmvilas
Copy link
Member Author

fmvilas commented Jun 15, 2022

Yeah, it's like every link is failing 😅 Or I'm failing to read the checks properly 😄

@derberg
Copy link
Member

derberg commented Jun 15, 2022

@fmvilas yeah you need to update with latest master again, where @KhudaDad414 made fixes

@fmvilas
Copy link
Member Author

fmvilas commented Jun 15, 2022

You're right 👍

@fmvilas
Copy link
Member Author

fmvilas commented Jun 15, 2022

/au

@fmvilas
Copy link
Member Author

fmvilas commented Jun 15, 2022

I wished 😄

@sonarcloud
Copy link

sonarcloud bot commented Jun 15, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@fmvilas
Copy link
Member Author

fmvilas commented Jun 15, 2022

Merging with master again would make me go through the conflicts again so I'm cherry-picking the commits that were not yet here from master.

@fmvilas
Copy link
Member Author

fmvilas commented Jun 15, 2022

@derberg CI still broken in this PR. Any idea why?

@derberg
Copy link
Member

derberg commented Jun 15, 2022

We need to investigate. It is not yet a blocking CI check so go ahead and merge. Some of fails are because there are already future links for 3.0. should be ignored in config. But I don't think it is the only issue

@fmvilas fmvilas merged commit f269234 into asyncapi:next-major-spec Jun 15, 2022
@fmvilas fmvilas deleted the merge-with-master branch June 15, 2022 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonaslagoni jonaslagoni jonaslagoni approved these changes

@smoya smoya smoya approved these changes

@derberg derberg Awaiting requested review from derberg derberg is a code owner

@dalelane dalelane Awaiting requested review from dalelane dalelane is a code owner

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

Assignees
No one assigned
Labels
autoupdate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@fmvilas @jonaslagoni @derberg @smoya @asyncapi-bot @quetzalliwrites @KhudaDad414